Ticket #20 (closed defect: fixed)

Opened 21 months ago

Last modified 18 months ago

"Return" button on label editing screen does nothing

Reported by: dgsachs@… Owned by: glen.low@…
Priority: high: does not work as expected Milestone: 1.3 sharing release
Version: 0.2 Keywords:
Cc:

Description

The Touch keypad displays a Return key in the label editing screen, but when you press it absolutely nothing happens.

Presently, with the label being the only editable property, the correct behavior would be to set the label and return to the main graph screen. However, since I imagine that there will be more editable properties in the future, the Return button should at least dismiss the keyboard and remove the cursor from the Label box.

Change History

Changed 21 months ago by glen.low@…

  • owner set to glen.low@…
  • status changed from new to accepted
  • milestone set to graph/node/edge settings

I like your first idea i.e. set the label and return the main graph screen. My finger intuitively went to the "return" button in order to dismiss the settings screen.

Surprisingly, there's no convention among Apple-supplied apps what to do.

  • In the Settings app, each text field has a "return" key, and tapping it advances to the next text field. Except if it's the last text field, in which case nothing happens. These screens often have other setting controls on them.
  • In some other apps e.g. Maps, each text field either has a "Next" key or a "Done" key. Tapping on "Next" advances to the next text field, tapping on "Done" returns to the original screen. These screens often have no other setting controls on them.

I've decided to follow the second behavior, and the return button will be clearly labelled as such. All this to enable the user to edit a label quickly since:

  • Double-tapping on a node, edge or graph gets you to the Settings screen, and then the label setting is focussed and the keyboard appears without needing any more taps.
  • After editing the label, the user's finger is likely to be close to the keyboard, so it's quicker to tap the "Done" button than it is to tap on the "Graph" button at the top.
  • If and when we eventually get multiple text fields in the space, tapping on "Next" a couple of times until it turns into "Done" achieves the same effect.

It remains to figure out how and when to dismiss the keyboard. Most of the Apple apps don't actually dismiss the keyboard once it comes up, although I only have an iPod Touch and not an iPhone so I don't know how SMS does it. Dismissing the keyboard will be useful when there are a lot of non-text settings, as with 0.3 and the final release... we'll raise it in another ticket.

Changed 21 months ago by glenlow

  • status changed from accepted to closed
  • resolution set to fixed

(In [29]) Tapping the label text field keyboard "return" key now dismisses the settings panel (fix #20). Settings view controller now remembers all editable cells.

Changed 18 months ago by glen.low@…

  • status changed from closed to reopened
  • resolution fixed deleted
  • milestone changed from graph/node/edge settings to last release before 2.0

I've changed my mind. Tapping on "Done" in the Export screen should not dismiss the Export screen since the action isn't typically done already, the actual Export button needs to be tapped as well. Thus I will change the behavior so that tapping on "Done" just dismisses the keyboard in all screens.

Changed 18 months ago by glenlow

  • status changed from reopened to closed
  • resolution set to fixed

(In [89]) Fixed Done keyboard button not working in Export when box.net or iDisk is selected (fix #63). Done button now always dismisses keyboard without popping the current view (fix #20). IVSettingsViewController now responsible for showing/hiding rows. Settings changed on each text field change instead of at end of editing.

Note: See TracTickets for help on using tickets.